Server Chatlogs get mixed between Servers!

[SilentStorm]

If enabled Serverchat gets logged in the server.txt inside the chats Folder which has a separate File / Folder for each and every Server visited, composed of the Server UID, which is all good. However there is a Bug which causes Serverchats to be mixed between servers.

It looks like the File gets opened once in the Folder corrosponding to the server connected to when a new Tab is connected for the first time and then any Output is just dumped into that file. This however causes a huge issue if that Tab gets reused at any time since the File is not closed when a new Connection is being made, resulting in Logs from Server B being written to the logfile belonging to Server A.

Reproduce:
Start TS3, connect to a Server (say Public Test Server), then disconnect and connect to another Server (say Public Community Server) without closing the Tab.
You will have Logs from both Servers in the Logfile of the Public Test Server.

I'd like to suggest to close the File either once the User disconnected manually from a Server (want_reconnect is 0) or once a Connection to a different Server is requested (ie. before established). That way any Connection attempts to the same server will still get logged into the correct File without having to open & close the same File repeatedly, but any Log Entries belonging to a different Server will be correctly put into the File for the new Server.

[MuhChy]

i just added this into our bugtracker.

Thank you SilentStorm

[MuhChy]

Our next upcoming betachannel client 3.0.7 should fix this problem.

[SilentStorm]

Our latest betachannel client 3.0.7 should fix this problem.

Just tried to get an update, said none available. Manually ran the Updater which downloaded something... Ran TS3 connected to a Server, then connected to a different Server in the same Tab. Log still merged into the File from the first connected Server!

Either this is not fixed or the Client hasn't been pushed onto the Update Server yet

[MuhChy]

;( yea sry i think you have to wait for the said beta push :/

[SilentStorm]

While Logs no longer get mixed, it now fails to log the Pre and Post Connection Entries.

[RicoH]

While Logs no longer get mixed, it now fails to log the Pre and Post Connection Entries.

What exactly do you mean?
Is it that server.txt is only filled with chat messages?

We don't log server messages in plain since version 3.0.3 anymore.

[SilentStorm]

I'm talking about the exact replica of the Chat as seen in the Client lower Frame (aka the html Files).
Before the Fix it did log for example

<13:50:10> Connection to server lost.
<13:50:15> Failed to connect to Server.
<13:50:20> Trying to resolve hostname ts3.example.com
<13:50:25> Trying to connect to server on ts3.example.com
<13:50:30> Connected to Server: Example TS3 Server

Now it just logs the last line and if you manually disconnect. Connection Lost, Trying to establish Connection / resolve Hostname are no longer logged. Presumably because it doesn't know which Logfile to use.

[RicoH]

You are right at the "Trying to ..." moment we don't know which logfile to use.

Logging is based on the servers unique identifier and the earliest moment to get it
is when connection state == STATUS_CONNECTED. Assuming that the server is just
restarting, everything could be logged fine but when connecting to another server the
serverUID at this moment is also unknown.

Of course, we could code a solution for this but we don't see an added value for just
having "Trying to..." to be logged.