setting client permissions ingores server groups b_client_skip_chan...

[Morfi]

Hello.

How to reproduce:
Server group "ADMIN"

i_client_move_power	100	0	0	100
i_client_needed_move_power	100	0	0	100
b_client_skip_channelgroup_permissions	1	0	0	100

Server group "MOD"

i_client_move_power	75	0	0	100
i_client_needed_move_power	75	0	0	100

User "Tom" has "ADMIN" server group.
User "Jerry" has "MOD" server group.

None of them has channel groups (Guest and Guest).

Jerry can't move Tom.


We assign for Tom new channel group.

Channel group "OPERATOR"

i_client_needed_move_power

50

0

0

100

User "Tom" has now "ADMIN" server group and "OPERATOR" channel group.

Jerry can't move Tom because "b_client_skip_channelgroup_permissions" does not allow "OPERATOR" to overwrite "ADMIN`s" i_client_needed_move_power.


Here comes the problem.

We assing "TOM" (CLDBID: 2) (via Client permissions, not channel/server group) new permission.

i_client_needed_move_power

100

0

-

100

Jerry can move Tom. (tom still should has 100 i_client_needed_move_power !)

EXPLANATION:
Somehow after assigning to TOM`s cldbid new permission, he lost in the same time immunity from "ADMIN`s" b_client_skip_channelgroup_permissions and i_client_needed_move_power 50 triggered even that in "Permission overview (all)" it says:

i_client_needed_move_power	100	0	0	100
b_client_skip_channelgroup_permissions	1	0	0	100

You could restore TOM's immunity by giving skip flag "1" to i_client_needed_move_power in "client permissions" (NOT "ADMIN" server group) OR assign b_client_skip_channelgroup_permissions 1 in "client permissions" once again (even that they were already assigned in Server group and nothing was overwriting them).



Thanks
Mike

[SilentStorm]

This works indeed, despite everything saying it shouldn't. Values don't really matter tested on my Server with 75 for Admin and 60 for Lesser Admin moving the Admin out if the Admin got a Channelgroup which lowers the needed_move_power.

It works the same way with kicking (both channel & server) and even banning... So I just banned my Server Admin ID which got ignore_bans as well with my lower Admin ID. Can reconnect right away because of ignore_bans but still...

As long as you have the same Permission from a Servergroup and as Client Permission, which then gets lowered by a Channelgroup (or Channel Permission) it works. (despite the fact that Channelgroup & Channelpermissions are skipped with the Big Skip Permission)

Nice catch and horrible Bug.

Edit: Bug is also present in Servers 3.0.5 and 3.0.6

[Morfi]

Thanks for deeper investigation. The fact that it can even ommit "ingore_bans" makes it even more ridiculous.

Credits for finding bug goes to S0uLy from my server.

[dante696]

I can reproduce this, but in my opinion the only bug here is, that the permission overview shows the wrong values for a permission.
Additional for this, i think The client permission "without skip flag" overwrites the skip fro mthe server group.

I have created a tcket for this problem/Behavior > We investigate some time for this.

Edit i mark this as an eval thread

[Morfi]

Even if it would overwrite the skip flag, it may not gloss over the b_client_skip_channelgroup_permissions from Server group!!

[SilentStorm]

If I remember correctly setting b_client_skip_channelgroup_permissions is the same as if you would set the Skip Flag for each and every Permission. It's just an easier, more direct way of saying this Group has all its permissions skipped.

I also remember something would change if you set Skip Flags for specific Permissions in a Group which already has b_client_skip_channelgroup_permissions but can't remember what and couldn't seem to find it in the 5 mins I spend either...

In any case seeing it this way it does make (at least some) sense why this is working the way it is.

It does no longer work once you skip the Client Permission to regain the skip Flag.

[dante696]

I can't reproduce this anymore with client 3.0.8.1

Edit
I mark this as resolved, there was no feedback yet.