Detailed Edit Server logging

[SilentStorm]

Currently whenever the Server gets edited all that gets logged is the Fact that a Server was edited and who did it.
I would like to suggest that the Logging gets more detailed (like Permission logging is) and includes exactly what changed, possibly even including the old and the new Value. So instead of

server was edited by 'Example' (id:1337)

it says

server was edited by 'Example' (id: 1337) : virtualserver_name = 'New Server Name' (original: 'Old Server Name'), virtualserver_max_clients = 100 (original: 50)

[Alcazar]

Could be useful, but changed property would suffice.
But lets see what Master Dante says, if he just rejects it or passed it to the Devs

[SilentStorm]

pssht... don't lower it up front already - they do that on their own
and at the very least the new value should be there. Including the old value makes it easier to track the changes, since you wouldn't need to sift through (possibly already deleted) old Logfiles to see what it was before.

[dante696]

I will pass that to the developers, but are you sure, that every detail should be logged?
Please answer this first.

I don't think, that the old value will be shown in the log files.

[SilentStorm]

Pretty much yeah...
I obviously wouldn't care or want to see the new Password in Plaintext in the logfiles and in that case a Notice like server was edited by 'Example' (id: 1337) :: Server Password got changed. or server was edited by 'Example' (id: 1337) :: Server Password was removed. (yes I think differentiating between changing / setting and removing a Password makes sense and could be valuable information).
But for pretty much everything else you can set in the Edit Virtual Server Dialog changes should be logged in detail, containing the Property that got changed and the new value. Including the old Value is a Bonus.
Text Values which contain potentially lengthy text (Welcome Message) might be largely omitted to not blow the log file unnecessarily, if possible include only the part that got changed or just a more generic "welcome message was changed" like with the password above.
Icon should include the numeric value for the new Icon, Changed Default Groups should be logged the way changed Groups are logged for Clients, Checkboxes, Integer Input Fields, Voice Encryption should all be logged with the respective new value.

[dante696]

I will add the ticket with these server paramters, but i won't reuqurst the details.
It should show "virtualserver_welcomemessage;" instead "virtualserver_welcomemessage=New Message"

Here an example of such a log entry.
20.08.2012 13:24:33 VirtualServer Info server was edited (virtualserver_name; virtualserver_password; virtualserver_icon_id) by 'dante'(id:3)

virtualserver_name
virtualserver_welcomemessage
virtualserver_maxclients
virtualserver_password
virtualserver_codec_encryption_mode
virtualserver_hostmessage
virtualserver_hostmessage_mode
virtualserver_default_server_group
virtualserver_default_channel_group
virtualserver_default_channel_admin_group
virtualserver_max_download_total_bandwidth
virtualserver_max_upload_total_bandwidth
virtualserver_hostbanner_url
virtualserver_hostbanner_gfx_url
virtualserver_hostbanner_gfx_interval
virtualserver_complain_autoban_count
virtualserver_complain_autoban_time
virtualserver_complain_remove_time
virtualserver_min_clients_in_channel_before_forced_silence
virtualserver_priority_speaker_dimm_modificator
virtualserver_antiflood_points_tick_reduce
virtualserver_antiflood_points_needed_command_block
virtualserver_antiflood_points_needed_ip_block
virtualserver_hostbutton_tooltip
virtualserver_hostbutton_url
virtualserver_hostbutton_gfx_url
virtualserver_download_quota
virtualserver_upload_quota
virtualserver_needed_identity_security_level
virtualserver_log_client
virtualserver_log_query
virtualserver_log_channel
virtualserver_log_permissions
virtualserver_log_server
virtualserver_log_filetransfer
virtualserver_name_phonetic
virtualserver_icon_id
virtualserver_reserved_slots
virtualserver_ip virtualserver_weblist_enabled
virtualserver_hostbanner_mode

This is all, what serverinfo gave me here (stripped server details like traffic and password flag etc.)

[varela1george]

Very nice,, that help...

We also need:

20.08.2012 13:24:33 Channel Info (my room) (id:123) was edited (channel_name; channel_password; channel_icon_id) by 'dante'(id:3)

20.08.2012 13:24:33 Channel (my room) (id:123) was deleted by 'dante'(id:3)

20.08.2012 13:24:33 Server group (serveradmin) (id:23) was edited by 'dante'(id:3)

20.08.2012 13:24:33 Server group (serveradmin) (id:23) was deleted by 'dante'(id:3)

I don't know how to write it, Well you know my idea.. we should know who delete some channels, edit channels and stuff

[SilentStorm]

With the exception of the first line (channel edited detailed logging) all of what you mentioned is already being logged.

[varela1george]

Well I haven't seen who has deleted a channel, i would like to know who did it. I would like to know who delete a channel and what channel

[PotaBlava]

Well I haven't seen who has deleted a channel, i would like to know who did it. I would like to know who delete a channel and what channel

Well, this is now available. See log about a permanent channel.

30/09/2012 11:51:41	VirtualServer	Info	channel 'Test for logging'(id:119) created as sub channel of 'Supervisor(id:54) by 'PotaBlava'(id:16)	
30/09/2012 11:51:56	VirtualServer	Info	channel 'Test for logging'(id:119) deleted by 'PotaBlava'(id:16)

Notes:
Server version: 3.0.6.1 (29/06/2012 9:59:05) Windows
Client version: 3.0.8.1 (30/07/2012 16:09:12) Windows
----