Forum

Page 2 of 3 FirstFirst 123 LastLast
Results 16 to 30 of 38
  1. #16
    Join Date
    June 2008
    Posts
    18,151
    It would solve the problem that the value is not stored in the database as it should.
    But biggest problem now would be that the client isn't able to set a channel icon any longer.

    We may overhaul this or the client or delay the change.
    When sending me private messages: Please make sure to include reference link to your forum thread or post.

    TeamSpeak FAQ || What should i report, when i open a client thread?

  2. #17
    Join Date
    June 2008
    Posts
    18,151
    Quote Originally Posted by dante696 View Post
    With next server version 3.9.0 we decided to deny when a user tries to set a channel icon with the channeledit command.
    Back to this.
    We evaluated if something would break. Everything works as expected.
    Clients still can set icons via permission or channel create/edit dialog and the ServerQuery allows to set icons with command channeladdperm cid=x i_icon_id=x

    Server 3.9.0 will no longer allow to use the channeledit command for this.
    When sending me private messages: Please make sure to include reference link to your forum thread or post.

    TeamSpeak FAQ || What should i report, when i open a client thread?

  3. #18
    Join Date
    October 2003
    Location
    Germany
    Posts
    2,527
    Just to clarify the situation... the reason why we decided to prevent the icon ID from being set using channeledit is that is was inconsistent behavior. Other commands like serveredit and clientedit do not allow setting the icon ID either since it's supposed to be changed via permission. What happened before is that channeledit updated the read-only channel property... which might seem convenient, but actually was a bug and lead to a series of issues such as the permissions not being updated.

    Anyway... we feel it's better to provide a consistent API to our users and there are a lot of other things we need to tackle in that area.

  4. #19
    Join Date
    February 2014
    Posts
    241
    Quote Originally Posted by ScP View Post
    Just to clarify the situation... the reason why we decided to prevent the icon ID from being set using channeledit is that is was inconsistent behavior. Other commands like serveredit and clientedit do not allow setting the icon ID either since it's supposed to be changed via permission. What happened before is that channeledit updated the read-only channel property... which might seem convenient, but actually was a bug and lead to a series of issues such as the permissions not being updated.

    Anyway... we feel it's better to provide a consistent API to our users and there are a lot of other things we need to tackle in that area.

    Do you have to channeldelperm each time to add a new perm or is there a way to edit it?

    With my testing if you try to set a new value with channeladdperm it will error with:

    channeladdperm cid=453 permsid=i_icon_id permvalue=2524640421
    error id=1540 msg=convert\serror


    as

    channeledit cid=453 channel_icon_id=2524640421

    Works consistently without any problems for me.
    Last edited by Patrick1164; June 13th, 2019 at 01:26 PM.

  5. #20
    Join Date
    October 2003
    Location
    Germany
    Posts
    2,527
    Quote Originally Posted by Patrick1164 View Post
    Do you have to channeldelperm each time to add a new perm or is there a way to edit it?
    Just calling channeladdperm again with the new value is enough.

    Quote Originally Posted by Patrick1164 View Post
    With my testing if you try to set a new value with channeladdperm it will error with:

    channeladdperm cid=453 permsid=i_icon_id permvalue=2524640421
    error id=1540 msg=convert\serror
    This will be fixed with the upcoming 3.9.0 server release.

  6. #21
    Join Date
    September 2016
    Posts
    76
    Quote Originally Posted by dante696 View Post
    Back to this.
    We evaluated if something would break. Everything works as expected.
    Clients still can set icons via permission or channel create/edit dialog and the ServerQuery allows to set icons with command channeladdperm cid=x i_icon_id=x

    Server 3.9.0 will no longer allow to use the channeledit command for this.
    Great, thanks for the clarification

  7. #22
    Join Date
    February 2014
    Posts
    241
    Quote Originally Posted by ScP View Post
    Just calling channeladdperm again with the new value is enough.

    This will be fixed with the upcoming 3.9.0 server release.

    Ah okay great thanks, wont update my code until 3.9 is running then!

  8. #23
    Join Date
    June 2011
    Location
    Germany
    Posts
    4,350
    Quote Originally Posted by ScP View Post
    Other commands like serveredit and clientedit do not allow setting the icon ID either since it's supposed to be changed via permission.
    Ehm, what?

  9. #24
    Join Date
    October 2003
    Location
    Germany
    Posts
    2,527
    Quote Originally Posted by numma_cway View Post
    Ehm, what?
    My mistake... obviously, the server itself has no permissions. So we're only talking about clientedit and channeledit.

  10. #25
    Join Date
    February 2014
    Posts
    241
    No mention of the fix for channeladdperm being able to change icon if channel already has perm in 3.9 changelog, is this included?

  11. #26
    Join Date
    June 2008
    Posts
    18,151
    There is no fix to set an icon with that command when a icon is set already.
    That worked before and still works.

    New is that you can use 2524640421 (Unsigned Int) or -1770326875 (Signed Int) to set an icon via permission commands.
    When sending me private messages: Please make sure to include reference link to your forum thread or post.

    TeamSpeak FAQ || What should i report, when i open a client thread?

  12. #27
    Join Date
    February 2014
    Posts
    241
    Quote Originally Posted by dante696 View Post
    There is no fix to set an icon with that command when a icon is set already.
    That worked before and still works.

    New is that you can use 2524640421 (Unsigned Int) or -1770326875 (Signed Int) to set an icon via permission commands.

    I don't understand, this doesn't work.

    I first set the channel with no icon perm to:

    channeladdperm cid=453 permsid=i_icon_id permvalue=2101350922
    error id=0 msg=ok

    Then:

    channeladdperm cid=453 permsid=i_icon_id permvalue=2524640421
    error id=1540 msg=convert\serror

    Third:

    channeladdperm cid=453 permsid=i_icon_id permvalue=3373850627
    error id=1540 msg=convert\serror

    But if I then do:

    channeladdperm cid=453 permsid=i_icon_id permvalue=-1770326875
    error id=0 msg=ok


    Is this fixed in 3.9?

  13. #28
    Join Date
    June 2008
    Posts
    18,151
    Are you talking about 3.8.0 where you get the errors?

    Yes this was changed (not fixed) for server 3.9.0 Beta1
    When sending me private messages: Please make sure to include reference link to your forum thread or post.

    TeamSpeak FAQ || What should i report, when i open a client thread?

  14. #29
    Join Date
    February 2014
    Posts
    241
    Quote Originally Posted by dante696 View Post
    Are you talking about 3.8.0 where you get the errors?

    Yes this was changed (not fixed) for server 3.9.0 Beta1
    Well you're disabling channel edit being able to set the icon, which I use in some code so I'm preparing for that change in 3.9, I wanted to know if this behaviour was changed so that you could set an icon via permission if the channel already has one.

    Is this now possible in 3.9?

  15. #30
    Join Date
    June 2011
    Location
    Germany
    Posts
    4,350
    Using channeledit to set icons never worked properly, so you shouldn't have done it before. That's why this thread was created. And TeamSpeak now removed a feature that never worked. So I don't see the issue.

    dante said that 3.9.0 accepts signed and unsigned integers.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Similar Threads

  1. [Resolved] setChannelVariable CHANNEL_ICON_ID impossible to change ID
    By MiguelSnake in forum Client Plugins / Lua Scripts
    Replies: 4
    Last Post: November 29th, 2016, 12:18 PM
  2. Is there an possibility to make channeledit silent?
    By globalcookie in forum Server Support
    Replies: 1
    Last Post: May 17th, 2016, 11:28 AM
  3. channel_icon_id problem (out of range)
    By filimonic in forum Linux / FreeBSD
    Replies: 1
    Last Post: June 19th, 2012, 11:07 AM
  4. [Resolved] ServerQuery channel_icon_id problem
    By devour in forum Linux / FreeBSD
    Replies: 1
    Last Post: January 26th, 2012, 09:02 AM
  5. Query channeledit and codec encrypted
    By florian_fr40 in forum Bug Reports [EN/DE]
    Replies: 5
    Last Post: October 13th, 2010, 11:04 AM

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •